boostorg/lexical_cast
1
0
Fork 0
mirror of https://github.com/boostorg/lexical_cast.git synced 2026-07-21 13:23:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed conversion of std::basic_string_view and boost::basic_string_view containing one or more \0 characters.

Browse Source 
Issue was introduced in 1.85.0
This commit is contained in:
Antony Polukhin
2024-07-07 20:08:13 +03:00
parent 7861401ac4
commit ff2f0496b0
3 changed files with 30 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
doc/lexical_cast.qbk
+5
View File
@@ -235,6 +235,11 @@ limitation of compiler options that you use.
[section Changes]
* [*boost 1.86.0 :]
* Fixed conversion of `std::basic_string_view` and `boost::basic_string_view`
containing one or more `\0` characters. Issue was introduced in 1.85.0.
* [*boost 1.85.0 :]
* Significant rewrite of the internal logic to separate optimized and C++ Standard Library IO-based streams:
include/boost/lexical_cast/detail/converter_lexical_streams.hpp
+6 -2
View File
@@ -346,13 +346,17 @@ namespace boost { namespace detail { namespace lcast {
template <class C, class CharTraits>
enable_if_compatible_char_t<C>
stream_in(lcast::exact<std::basic_string_view<C, CharTraits>> x) noexcept {
return shl_char_array_limited(reinterpret_cast<const CharT*>(x.payload.data()), x.payload.size());
start = reinterpret_cast<const CharT*>(x.payload.data());
finish = start + x.payload.size();
return true;
}
#endif
template <class C, class CharTraits>
enable_if_compatible_char_t<C>
stream_in(lcast::exact<boost::basic_string_view<C, CharTraits>> x) noexcept {
return shl_char_array_limited(reinterpret_cast<const CharT*>(x.payload.data()), x.payload.size());
start = reinterpret_cast<const CharT*>(x.payload.data());
finish = start + x.payload.size();
return true;
}
};
test/string_view_test.cpp
+19 -7
View File
@@ -19,18 +19,30 @@
#include <boost/core/lightweight_test.hpp>
using namespace boost;
template <class StringView>
void test_string_view_conversion() {
using boost::lexical_cast;
StringView sw = "1";
BOOST_TEST_EQ(lexical_cast<std::string>(sw), "1");
BOOST_TEST_EQ(lexical_cast<int>(sw), 1);
sw = StringView("a\0b", 3);
BOOST_TEST_EQ(lexical_cast<std::string>(sw), std::string("a\0b", 3));
sw = StringView("a\0b", 4);
BOOST_TEST_EQ(lexical_cast<std::string>(sw), std::string("a\0b", 4));
sw = StringView("\0a\0", 3);
BOOST_TEST_EQ(lexical_cast<std::string>(sw), std::string("\0a\0", 3));
}
int main() {
boost::string_view bsw = "1";
BOOST_TEST_EQ(lexical_cast<std::string>(bsw), "1");
BOOST_TEST_EQ(lexical_cast<int>(bsw), 1);
test_string_view_conversion<boost::string_view>();
#ifndef BOOST_NO_CXX17_HDR_STRING_VIEW
std::string_view ssw = "42";
BOOST_TEST_EQ(lexical_cast<std::string>(ssw), "42");
BOOST_TEST_EQ(lexical_cast<int>(ssw), 42);
test_string_view_conversion<std::string_view>();
#endif
return boost::report_errors();