mirror of
https://github.com/AntelopeIO/boringssl.git
synced 2026-07-21 14:43:53 +00:00
David Benjamin
056035edcc
This dates to https://boringssl-review.googlesource.com/2850, which was done in response to an ARM crash. I assume the ARM crash was due to poly1305_arm.c casting pointers around, which is technically UB, even on x86 since C says it is UB to cast pointers if the value would be unaligned. (Also I believe it's a strict aliasing violation, though the compilers really ought to give us a sanitizer for it if they're excited about that optimization.) Replace with memcpy, which any reasonable compiler would compile the same on platforms that support unaligned access. ARM does support it these days, so perhaps the crash came from an older ARM? Benchmarks showed no difference with this CL. Change-Id: I022bdb84f95e45c143ad19359f646ee1416d5ae9 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/39344 Commit-Queue: Adam Langley <agl@google.com> Reviewed-by: Adam Langley <agl@google.com>
50 lines
1.9 KiB
C
50 lines
1.9 KiB
C
/* Copyright (c) 2014, Google Inc.
|
|
*
|
|
* Permission to use, copy, modify, and/or distribute this software for any
|
|
* purpose with or without fee is hereby granted, provided that the above
|
|
* copyright notice and this permission notice appear in all copies.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
|
|
* SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
|
|
* OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
|
|
* CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */
|
|
|
|
#ifndef OPENSSL_HEADER_POLY1305_H
|
|
#define OPENSSL_HEADER_POLY1305_H
|
|
|
|
#include <openssl/base.h>
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif
|
|
|
|
|
|
typedef uint8_t poly1305_state[512];
|
|
|
|
// CRYPTO_poly1305_init sets up |state| so that it can be used to calculate an
|
|
// authentication tag with the one-time key |key|. Note that |key| is a
|
|
// one-time key and therefore there is no `reset' method because that would
|
|
// enable several messages to be authenticated with the same key.
|
|
OPENSSL_EXPORT void CRYPTO_poly1305_init(poly1305_state *state,
|
|
const uint8_t key[32]);
|
|
|
|
// CRYPTO_poly1305_update processes |in_len| bytes from |in|. It can be called
|
|
// zero or more times after poly1305_init.
|
|
OPENSSL_EXPORT void CRYPTO_poly1305_update(poly1305_state *state,
|
|
const uint8_t *in, size_t in_len);
|
|
|
|
// CRYPTO_poly1305_finish completes the poly1305 calculation and writes a 16
|
|
// byte authentication tag to |mac|.
|
|
OPENSSL_EXPORT void CRYPTO_poly1305_finish(poly1305_state *state,
|
|
uint8_t mac[16]);
|
|
|
|
|
|
#if defined(__cplusplus)
|
|
} // extern C
|
|
#endif
|
|
|
|
#endif // OPENSSL_HEADER_POLY1305_H
|